Re: [PATCH v3 14/25] system/memory: Use explicit endianness in ram_device::read/write()

[Philippe Mathieu-Daudé]

On 28/12/25 12:12, Paolo Bonzini wrote:

Il mer 24 dic 2025, 16:24 Philippe Mathieu-Daudé <phi...@linaro.org <mailto:phi...@linaro.org>> ha scritto:

    Replace the ldn_he_p/stn_he_p() calls by their explicit endianness
    variants. Duplicate the MemoryRegionOps, using one entry for BIG
    and another for LITTLE endianness. Select the proper MemoryRegionOps
    in memory_region_init_ram_device_ptr().

This extra complication makes no sense to me. You're introducing dead code and dead data, because only one of the MemoryRegionOps will be ever used on a given host.

Given this example and the ATI one, I would really prefer to keep _he_ functions around and use them whenever you're reading from host memory as in this case.

Ack, patch dropped.