Il sab 27 dic 2025, 16:45 Philippe Mathieu-Daudé <[email protected]> ha scritto:
> Hi Paolo, > > On 27/12/25 10:14, Paolo Bonzini wrote: > > Move RAMBlock functions out of ram_addr.h and cpu-common.h; > > move memory API headers out of include/exec and into include/system. > > I know you want the good of the project and make it evolve, > but TBH pushing your own unreviewed patches without looking > at others work in the same area is really demotivating, it > feel like you completely ignore us. > This cleanup was posted over a month ago and I didn't get any reviews... it does absolutely nothing except splitting up a couple header files so that they do what the names signify, so I didn't think too much about it and thought people didn't really care. Sorry for not spotting the duplicate patch among your patches—what happened is that I agreed with the general idea and, seeing Richard and others reviewing them, I trusted both you and them; I only looked at them closely today after you pointed out the duplication. Rest assured that it's really trusting the people that are working on QEMU, like you (or Peter or David for the memory API) and not ignoring them. Paolo > > Signed-off-by: Paolo Bonzini <[email protected]> > > --- > > MAINTAINERS | 2 +- > > include/exec/cpu-common.h | 74 ----------- > > include/exec/cputlb.h | 1 + > > include/exec/translation-block.h | 2 + > > include/hw/core/qdev-properties-system.h | 1 + > > include/hw/i2c/smbus_eeprom.h | 2 +- > > include/hw/xen/xen-hvm-common.h | 1 + > > include/system/balloon.h | 2 +- > > include/system/block-ram-registrar.h | 2 +- > > include/system/iommufd.h | 2 +- > > include/system/memory.h | 16 ++- > > include/system/memory_mapping.h | 4 +- > > include/system/physmem.h | 2 +- > > include/system/ram_addr.h | 136 +++---------------- > > include/system/ramblock.h | 160 ++++++++++++++++++++++- > > include/{exec => system}/ramlist.h | 10 +- > > include/system/xen-mapcache.h | 1 - > > include/system/xen.h | 3 +- > > migration/migration.h | 3 +- > > migration/ram.h | 1 + > > accel/mshv/mshv-all.c | 1 + > > accel/tcg/cputlb.c | 2 +- > > accel/tcg/tcg-accel-ops-mttcg.c | 1 + > > backends/hostmem.c | 1 + > > block/blkio.c | 2 +- > > dump/dump.c | 1 + > > hw/acpi/ghes.c | 1 + > > hw/acpi/nvdimm.c | 1 + > > hw/acpi/vmgenid.c | 1 + > > hw/arm/omap1.c | 1 + > > hw/audio/marvell_88w8618.c | 1 + > > hw/char/riscv_htif.c | 1 + > > hw/core/cpu-common.c | 1 + > > hw/core/machine-qmp-cmds.c | 1 + > > hw/core/numa.c | 3 +- > > hw/display/exynos4210_fimd.c | 1 + > > hw/display/omap_lcdc.c | 1 + > > hw/display/ramfb.c | 1 + > > hw/display/vga.c | 1 + > > hw/dma/i8257.c | 1 + > > hw/dma/omap_dma.c | 1 + > > hw/dma/rc4030.c | 1 + > > hw/dma/sifive_pdma.c | 1 + > > hw/hyperv/hyperv.c | 1 + > > hw/hyperv/syndbg.c | 1 + > > hw/hyperv/vmbus.c | 1 + > > hw/i386/kvm/clock.c | 1 + > > hw/i386/vapic.c | 1 + > > hw/intc/apic.c | 1 + > > hw/intc/xive2.c | 1 + > > hw/m68k/next-cube.c | 1 + > > hw/microblaze/boot.c | 1 + > > hw/misc/pc-testdev.c | 1 + > > hw/net/fsl_etsec/rings.c | 1 + > > hw/net/mcf_fec.c | 1 + > > hw/net/opencores_eth.c | 1 + > > hw/net/xgmac.c | 1 + > > hw/nvram/spapr_nvram.c | 1 + > > hw/ppc/amigaone.c | 1 + > > hw/ppc/e500.c | 1 + > > hw/ppc/pegasos.c | 1 + > > hw/ppc/pnv.c | 1 + > > hw/ppc/ppc440_uc.c | 1 + > > hw/ppc/spapr.c | 1 + > > hw/ppc/spapr_drc.c | 1 + > > hw/ppc/spapr_events.c | 1 + > > hw/ppc/spapr_hcall.c | 1 + > > hw/ppc/spapr_rtas.c | 1 + > > hw/ppc/spapr_tpm_proxy.c | 1 + > > hw/ppc/virtex_ml507.c | 1 + > > hw/remote/proxy-memory-listener.c | 1 + > > hw/s390x/css.c | 1 + > > hw/s390x/ipl.c | 1 + > > hw/s390x/s390-pci-bus.c | 1 + > > hw/s390x/s390-stattrib.c | 1 + > > hw/s390x/virtio-ccw.c | 1 + > > hw/scsi/vmw_pvscsi.c | 1 + > > hw/sparc/leon3.c | 1 + > > hw/vfio-user/container.c | 1 + > > hw/vfio/container.c | 2 +- > > hw/vfio/helpers.c | 1 + > > hw/vfio/migration.c | 2 +- > > hw/virtio/vhost.c | 1 + > > hw/xen/xen-mapcache.c | 1 + > > hw/xen/xen_pt_graphics.c | 1 + > > hw/xtensa/xtfpga.c | 1 + > > migration/ram.c | 2 +- > > stubs/physmem.c | 2 +- > > stubs/ram-block.c | 4 +- > > system/ioport.c | 1 + > > system/memory.c | 2 +- > > system/physmem.c | 2 +- > > target/arm/kvm.c | 1 + > > target/i386/kvm/kvm.c | 1 + > > target/i386/sev.c | 1 + > > target/ppc/kvm.c | 2 +- > > target/s390x/kvm/kvm.c | 2 +- > > tests/qtest/fuzz/generic_fuzz.c | 2 +- > > util/vfio-helpers.c | 2 +- > > rust/hw/char/pl011/src/bindings.rs | 4 +- > > rust/hw/core/src/bindings.rs | 2 +- > > rust/system/src/bindings.rs | 5 +- > > 102 files changed, 298 insertions(+), 234 deletions(-) > > rename include/{exec => system}/ramlist.h (94%) > >
