Re: [PATCH v2 1/1] target/hppa: add 64 bit support to gdbstub

[Philippe Mathieu-Daudé]

On 13/11/25 05:48, Sven Schnelle wrote:

Signed-off-by: Sven Schnelle <sv...@stackframe.org>
---
  target/hppa/gdbstub.c | 62 ++++++++++++++++++++++++++++---------------
  1 file changed, 41 insertions(+), 21 deletions(-)

diff --git a/target/hppa/gdbstub.c b/target/hppa/gdbstub.c
index 0daa52f7af..777f4a48b9 100644
--- a/target/hppa/gdbstub.c
+++ b/target/hppa/gdbstub.c
@@ -21,16 +21,25 @@
  #include "cpu.h"
  #include "gdbstub/helpers.h"

-/*

- * GDB 15 only supports PA1.0 via the remote protocol, and ignores
- * any provided xml.  Which means that any attempt to provide more
- * data results in "Remote 'g' packet reply is too long".
- */
+static int hppa_num_regs(CPUHPPAState *env)
+{
+    return hppa_is_pa20(env) ? 96 : 128;
+}
+
+static int hppa_reg_size(CPUHPPAState *env)
+{
+    return hppa_is_pa20(env) ? 8 : 4;
+}

int hppa_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n)

  {
-    CPUHPPAState *env = cpu_env(cs);
-    uint32_t val;
+    HPPACPU *cpu = HPPA_CPU(cs);

'cpu' variable is not used, why introduce it?

+    CPUHPPAState *env = &cpu->env;
+    target_ulong val;
+
+    if (n >= hppa_num_regs(env)) {
+        return 0;
+    }

switch (n) {

      case 0:
@@ -133,24 +142,35 @@ int hppa_cpu_gdb_read_register(CPUState *cs, GByteArray 
*mem_buf, int n)
          val = env->cr[30];
          break;
      case 64 ... 127:
-        val = extract64(env->fr[(n - 64) / 2], (n & 1 ? 0 : 32), 32);
-        break;
-    default:
-        if (n < 128) {
-            val = 0;
+        if (hppa_is_pa20(env)) {
+            val = env->fr[n - 64];
          } else {
-            return 0;
+            val = extract64(env->fr[(n - 64) / 2], (n & 1 ? 0 : 32), 32);
          }
          break;
+    default:
+        val = 0;
+        break;
      }

- return gdb_get_reg32(mem_buf, val);

+    if (hppa_is_pa20(env)) {
+        return gdb_get_reg64(mem_buf, val);
+    } else {
+        return gdb_get_reg32(mem_buf, val);
+    }
  }

int hppa_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)

  {
-    CPUHPPAState *env = cpu_env(cs);
-    uint32_t val = ldl_p(mem_buf);
+    HPPACPU *cpu = HPPA_CPU(cs);

Ditto.

+    CPUHPPAState *env = &cpu->env;
+    target_ulong val;
+
+    if (n >= hppa_num_regs(env)) {
+        return 0;
+    }
+
+    val = ldn_p(mem_buf, hppa_reg_size(env));

switch (n) {

      case 0:
@@ -267,16 +287,16 @@ int hppa_cpu_gdb_write_register(CPUState *cs, uint8_t 
*mem_buf, int n)
          cpu_hppa_loaded_fr0(env);
          break;
      case 65 ... 127:
-        {
+        if (hppa_is_pa20(env)) {
+            env->fr[n - 64] = val;
+        } else {
              uint64_t *fr = &env->fr[(n - 64) / 2];
              *fr = deposit64(*fr, (n & 1 ? 0 : 32), 32, val);
          }
          break;
      default:
-        if (n >= 128) {
-            return 0;
-        }
          break;
      }
-    return 4;
+
+    return hppa_reg_size(env);
  }