On 1/1/26 12:38 AM, Paolo Bonzini wrote:
Il mer 31 dic 2025, 08:34 Pierrick Bouvier <[email protected]
<mailto:[email protected]>> ha scritto:
This headers conflicts with C++ ctype header, included from iostream.
Signed-off-by: Pierrick Bouvier <[email protected]
<mailto:[email protected]>>
Stupid question sorry: the header is meant to be included as qemu/
ctype.h, not ctype.h; why is include/qemu/ on the include path instead
of just include/? Can the include path be changed instead?
That's not a stupid question. Looking at it, inclusion comes from
plugins themselves, to include <qemu-plugin.h> instead of
<qemu/qemu-plugin.h>. I thought it was needed somewhere else also.
I think the rationale is to make sure that people can't pull anything
out of include/qemu from plugins code, which makes sense. That said,
there is still a lot of stuff that can be included from this folder.
Thinking about all this, a good solution could be to isolate
<qemu-plugin.h> in a new subfolder (include/plugins). This way, we make
sure plugins are properly isolated, and there won't be any conflict with
existing ctype header, so this patch can be dropped.
What do you think about this?
Paolo
Regards,
Pierrick
