Re: [PATCH v2 03/11] plugins: use complete filename for defining plugins sources

[Manos Pitsidianakis]

On Fri, 02 Jan 2026 23:47, Pierrick Bouvier <pierrick.bouv...@linaro.org> wrote:

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
---

Reviewed-by: Manos Pitsidianakis <manos.pitsidiana...@linaro.org>

contrib/plugins/meson.build   | 12 ++++++------
tests/tcg/plugins/meson.build |  9 ++++++---
2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/contrib/plugins/meson.build b/contrib/plugins/meson.build
index 8f9f0257ee5..3d2d7862e0c 100644
--- a/contrib/plugins/meson.build
+++ b/contrib/plugins/meson.build
@@ -1,16 +1,16 @@
-contrib_plugins = ['bbv', 'cache', 'cflow', 'drcov', 'execlog', 'hotblocks',
-                   'hotpages', 'howvec', 'hwprofile', 'ips', 'stoptrigger',
-                   'traps', 'uftrace']
+contrib_plugins = ['bbv.c', 'cache.c', 'cflow.c', 'drcov.c', 'execlog.c',
+                   'hotblocks.c', 'hotpages.c', 'howvec.c', 'hwprofile.c',
+                   'ips.c', 'stoptrigger.c', 'traps.c', 'uftrace.c']
if host_os != 'windows'
  # lockstep uses socket.h
-  contrib_plugins += 'lockstep'
+  contrib_plugins += 'lockstep.c'
endif

t = []
if get_option('plugins')
  foreach i : contrib_plugins
-    t += shared_module(i, files(i + '.c'),
-                      dependencies: plugins_deps)
+    t += shared_module(fs.stem(i), files(i),
+                       dependencies: plugins_deps)
  endforeach
endif
if t.length() > 0
diff --git a/tests/tcg/plugins/meson.build b/tests/tcg/plugins/meson.build
index c58f2e382ae..303f97f9679 100644
--- a/tests/tcg/plugins/meson.build
+++ b/tests/tcg/plugins/meson.build
@@ -1,8 +1,11 @@
+test_plugins = ['bb.c', 'discons.c', 'empty.c', 'inline.c', 'insn.c', 'mem.c',
+                'reset.c', 'syscall.c', 'patch.c']
+
t = []
if get_option('plugins')
-  foreach i : ['bb', 'discons', 'empty', 'inline', 'insn', 'mem', 'reset', 
'syscall', 'patch']
-    t += shared_module(i, files(i + '.c'),
-                      dependencies: plugins_deps)
+  foreach i : test_plugins
+    t += shared_module(fs.stem(i), files(i),
+                       dependencies: plugins_deps)
  endforeach
endif
if t.length() > 0
--
2.47.3