On Mon, Jan 05, 2026 at 03:56:49PM +0000, Yunpeng Yang wrote: > Hi Philippe, > > Thank you for your comments. > I've modified my patches according to your advice. > > Kind regards, > Yunpeng > > > v1...v2: > --- > 1. `is_valid_netmask` is renamed to `is_ipv4_netmask_valid`, and is now > implemented using `ldl_be_p`, `clo32`, and `ctz32`. It still ensures > the netmask is not `0.0.0.0`. > I didn't find any related helper functions in `include/`.
I couldn't find anything, either. > 2. Now the `IPMILan` structure has its own `VMStateDescription`. It's > linked to the parent `VMStateDescription` using `VMSTATE_STRUCT`. > --- > This looks good to me, I'll pull this in to my tree and pass it on. -corey > > Links: > * version 1 patches: > https://lists.gnu.org/archive/html/qemu-devel/2025-10/msg07505.html > * comments from Philippe Mathieu-Daudé <[email protected]>: > https://lists.gnu.org/archive/html/qemu-devel/2025-12/msg00117.html > > > Yunpeng Yang (2): > hw/ipmi/ipmi_bmc_sim: Support getting fake LAN channel config > hw/ipmi/ipmi_bmc_sim: Support setting fake LAN channel config > > hw/ipmi/ipmi_bmc_sim.c | 412 +++++++++++++++++++++++++++++++++++- > include/hw/ipmi/ipmi.h | 1 + > qemu-options.hx | 26 +++ > tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++ > 4 files changed, 572 insertions(+), 10 deletions(-) > > -- > 2.43.7 >
