Hi Caleb. I wonder if it makes sense to upstream this commit since I suspect that most upstream users will not have the "unimp" log messages enabled unless they are debugging a problem and in that case, we would be erroneously masking these unimplemented registers from the logged output.
Thanks, Glenn On Thu, 2025-12-18 at 14:03 -0600, Caleb Schlossin wrote: > This commit suppresses the following informational messages > regarding unimplemented pnv_chiptod registers: > > pnv_chiptod: unimplemented register: Ox0 > pnv_chiptod: unimplemented register: Ox1 > pnv_chiptod: unimplemented register: Ox2 > pnv_chiptod: unimplemented register: Ox3 > pnv_chiptod: unimplemented register: Ox4 > pnv_chiptod: unimplemented register: Ox5 > pnv_chiptod: unimplemented register: Ox13 > > Signed-off-by: Glenn Miles <[email protected]> > Signed-off-by: Caleb Schlossin <[email protected]> > --- > hw/ppc/pnv_chiptod.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/hw/ppc/pnv_chiptod.c b/hw/ppc/pnv_chiptod.c > index f887a18cde..cd9b8ee348 100644 > --- a/hw/ppc/pnv_chiptod.c > +++ b/hw/ppc/pnv_chiptod.c > @@ -145,6 +145,15 @@ static uint64_t pnv_chiptod_xscom_read(void *opaque, > hwaddr addr, > val |= PPC_BIT(4); > } > break; > + case TOD_M_PATH_CTRL_REG: > + case TOD_PRI_PORT_0_CTRL_REG: > + case TOD_PRI_PORT_1_CTRL_REG: > + case TOD_SEC_PORT_0_CTRL_REG: > + case TOD_SEC_PORT_1_CTRL_REG: > + case TOD_S_PATH_CTRL_REG: > + case TOD_TX_TTYPE_2_REG: > + /* unimplemented, but suppressing logging for now */ > + break; > default: > qemu_log_mask(LOG_UNIMP, "pnv_chiptod: unimplemented register: Ox%" > HWADDR_PRIx "\n", addr >> 3); > @@ -420,6 +429,15 @@ static void pnv_chiptod_xscom_write(void *opaque, hwaddr > addr, > case TOD_TX_TTYPE_5_REG: > pctc->broadcast_ttype(chiptod, offset); > break; > + case TOD_M_PATH_CTRL_REG: > + case TOD_PRI_PORT_0_CTRL_REG: > + case TOD_PRI_PORT_1_CTRL_REG: > + case TOD_SEC_PORT_0_CTRL_REG: > + case TOD_SEC_PORT_1_CTRL_REG: > + case TOD_S_PATH_CTRL_REG: > + case TOD_TX_TTYPE_2_REG: > + /* unimplemented, but suppressing logging for now */ > + break; > default: > qemu_log_mask(LOG_UNIMP, "pnv_chiptod: unimplemented register: Ox%" > HWADDR_PRIx "\n", addr >> 3);
