On Wed, 2025-12-10 at 15:54 -0500, [email protected] wrote:
> From: Jared Rossi <[email protected]>
> 
> Store both the device type (e.g. block) and device bus (e.g. CCW) to determine
> IPL format rather than assume all devices can be identified by CCW specific
> sense data.
> 
> Signed-off-by: Jared Rossi <[email protected]>
> ---
>  hw/s390x/ipl.h                   |  5 ----
>  include/hw/s390x/ipl/qipl.h      |  7 ++++++
>  pc-bios/s390-ccw/iplb.h          |  4 ----
>  pc-bios/s390-ccw/virtio.h        |  2 ++
>  pc-bios/s390-ccw/main.c          | 10 +++++---
>  pc-bios/s390-ccw/virtio-blkdev.c | 39 +++++++++++++++++++-------------
>  pc-bios/s390-ccw/virtio.c        | 13 +++++++----
>  7 files changed, 48 insertions(+), 32 deletions(-)

I might've suggested that this be broken up even further, to distinguish 
between the vdev->ipl_type
(nee iplb.pbt) and the vdev->dev_type (nee vdev->senseid.cu_model) changes, and 
maybe even the
consolidation of the S390_IPL_TYPE_* defines, to make it more obvious that 
things are just moving
around without any actual change. But, this is honestly fine.

Reviewed-by: Eric Farman <[email protected]>

Reply via email to