Re: [PULL 14/17] error: Use error_setg_errno() to improve error messages

[Richard Henderson]

On 1/7/26 23:43, Markus Armbruster wrote:
@@ -2032,7 +2032,8 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, Error 
**errp)
          reg.addr = (uint64_t)&val;
          ret = ioctl(kvmcpu.cpufd, KVM_GET_ONE_REG, &reg);
          if (ret != 0) {
-            error_setg(errp, "Unable to read cbom_blocksize, error %d", errno);
+            error_setg(errp, errno,
+                       "Unable to read cbom_blocksize");
              return;
          }
  

Missed changing the function.

../target/riscv/kvm/kvm-cpu.c:2035:13: error: passing argument 5 of ‘error_setg_internal’ 
makes pointer from integer without a cast [-Wint-conversion]
 2035 |             error_setg(errp, errno,
      |             ^~~~~~~~~~
      |             |
      |             int
In file included from ../target/riscv/kvm/kvm-cpu.c:26:
../include/qapi/error.h:322:38: note: expected ‘const char *’ but argument is 
of type ‘int’
  322 |                          const char *fmt, ...)
      |                          ~~~~~~~~~~~~^~~

https://gitlab.com/qemu-project/qemu/-/jobs/12639739827


r~