On 08/01/2026 11.21, Richard Henderson wrote:
On 1/8/26 20:47, Thomas Huth wrote:
On 08/01/2026 06.29, Richard Henderson wrote:
Remove instances of __i386__, except from tests and imported headers.
Signed-off-by: Richard Henderson <[email protected]>
---
...
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 2060e561a2..63713f1992 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -7449,15 +7449,6 @@ void syscall_init(void)
~(TARGET_IOC_SIZEMASK <<
TARGET_IOC_SIZESHIFT)) |
(size << TARGET_IOC_SIZESHIFT);
}
-
- /* automatic consistency check if same arch */
-#if (defined(__i386__) && defined(TARGET_I386) && defined(TARGET_ABI32))
|| \
- (defined(__x86_64__) && defined(TARGET_X86_64))
This looks like we should keep the x86_64 part?
- if (unlikely(ie->target_cmd != ie->host_cmd)) {
- fprintf(stderr, "ERROR: ioctl(%s): target=0x%x host=0x%x\n",
- ie->name, ie->target_cmd, ie->host_cmd);
- }
-#endif
The block doesn't look worthwhile to keep, IMO.
Ok, fine for me. Maybe mention it in the patch description, though, since
this was not obvious (at least not to me).
Thomas
