On Thu, 8 Jan 2026 at 01:39, Philippe Mathieu-Daudé <[email protected]> wrote:
> machine.c doesn't use any target-specific macro defined by
> the "migration/cpu.h" header. Use the minimum header requiered:

* requiered -> required

> "migration/qemu-file-types.h" and "migration/vmstate.h", which are not 
> target-specific.

* They are included via migration/cpu.h; Still the change looks okay.

> diff --git a/target/hppa/machine.c b/target/hppa/machine.c
> index 13e555151a6..6a143cf8df2 100644
> --- a/target/hppa/machine.c
> +++ b/target/hppa/machine.c
> @@ -19,7 +19,8 @@
>
>  #include "qemu/osdep.h"
>  #include "cpu.h"
> -#include "migration/cpu.h"
> +#include "migration/qemu-file-types.h"
> +#include "migration/vmstate.h"

Reviewed-by: Prasad Pandit <[email protected]>

Thank you.
---
  - Prasad


Reply via email to