On 1/8/26 22:52, Pierrick Bouvier wrote:
On 1/8/26 9:43 AM, Michael Tokarev wrote:
All linux targets these days have epoll_pwait system call
(while some miss epoll_wait, which is less generic).  And
all linux targets definitely has one or another epoll_*wait*
system call - so whole code block dealing with this system
call should always be present.

Remove the now-unneeded ifdeff'ery.

Signed-off-by: Michael Tokarev <[email protected]>
---
  linux-user/syscall.c | 8 +-------
  1 file changed, 1 insertion(+), 7 deletions(-)


Makes sense:

        epoll_wait()
               Linux 2.6, glibc 2.3.2.

        epoll_pwait()
               Linux 2.6.19, glibc 2.6.

Which has made this available for 9 years.

This is not it, Pierrick :)

qemu ships its own copy of linux headers with all these
__NR_foo definitions.  We don't have to deal with local
linux headers, we know exactly and precisely what we ship
and which targets defines which syscalls.  Once all arches
has __NR_epoll_wait *in our copy of linux-headers*, we're
all set.  No matter if it was 9 years ago or yesterday.
TARGET_NR_foo is what *we* know, - and it might be much
more fresh than the host kernel we're running on.

Thanks,

/mjt

Reply via email to