During reset, when the VM file descriptor is changed, the TDX state needs to be re-initialized. A pre-VMFD notifier callback is implemented to reset the old state and free memory before the new state is initialized post VM-fd change.
Signed-off-by: Ani Sinha <[email protected]> --- target/i386/kvm/tdx.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index cba07785f7..314d316b7c 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -405,6 +405,32 @@ static void tdx_handle_reset(Object *obj, ResetType type) trace_tdx_handle_reset(); } +/* TDX guest reset will require us to reinitialize some of tdx guest state. */ +static int set_tdx_vm_uninitialized(NotifierWithReturn *notifier, + void *data, Error** errp) +{ + TdxFirmware *fw = &tdx_guest->tdvf; + + if (tdx_guest->initialized) { + tdx_guest->initialized = false; + } + + g_free(tdx_guest->ram_entries); + + /* + * the firmware entries will be parsed again, see + * x86_firmware_configure() -> tdx_parse_tdvf() + */ + fw->entries = 0; + g_free(fw->entries); + + return 0; +} + +static NotifierWithReturn tdx_vmfd_pre_change_notifier = { + .notify = set_tdx_vm_uninitialized, +}; + /* * Some CPUID bits change from fixed1 to configurable bits when TDX module * supports TDX_FEATURES0.VE_REDUCTION. e.g., MCA/MCE/MTRR/CORE_CAPABILITY. @@ -1549,6 +1575,7 @@ static void tdx_guest_init(Object *obj) tdx->event_notify_vector = -1; tdx->event_notify_apicid = -1; + kvm_vmfd_add_pre_change_notifier(&tdx_vmfd_pre_change_notifier); qemu_register_resettable(obj); } -- 2.42.0
