On Thu, 4 Dec 2025 at 09:35, Corvin Köhne <[email protected]> wrote:
>
> From: YannickV <[email protected]>
>
> This commit offers some documentation on the Beckhoff CX7200
> qemu emulation.
>
> Signed-off-by: YannickV <[email protected]>
> ---
>  docs/system/arm/beckhoff-cx7200.rst | 57 +++++++++++++++++++++++++++++
>  docs/system/target-arm.rst          |  1 +
>  2 files changed, 58 insertions(+)
>  create mode 100644 docs/system/arm/beckhoff-cx7200.rst
>
> diff --git a/docs/system/arm/beckhoff-cx7200.rst 
> b/docs/system/arm/beckhoff-cx7200.rst
> new file mode 100644
> index 0000000000..f060319b0f
> --- /dev/null
> +++ b/docs/system/arm/beckhoff-cx7200.rst
> @@ -0,0 +1,57 @@
> +Beckhoff CX7200 (``beckhoff-cx7200``)
> +======================================
> +The Beckhoff CX7200 is based on the same architecture as the Xilinx Zynq A9.
> +The Zynq 7000 family is based on the AMD SoC architecture. These products
> +integrate a feature-rich dual or single-core Arm Cortex-A9 MPCore based
> +processing system (PS) and AMD programmable logic (PL) in a single device.
> +The Beckhoff Communication Controller (CCAT) can be found in the PL of Zynq.
> +
> +More details here:
> +https://docs.amd.com/r/en-US/ug585-zynq-7000-SoC-TRM/Zynq-7000-SoC-Technical-Reference-Manual
> +https://www.beckhoff.com/de-de/produkte/ipc/embedded-pcs/cx7000-arm-r-cortex-r/cx7293.html

This doesn't render very nicely in the HTML documentation,
because it comes out as two bare URLs with no line break
between them. Can you write this as something which uses
the rST syntax for links, please, e.g:

You can find more detail about this board on
`the manufacturer's product page <https://....>`__.
The SoC is documented in the
`Zynq 7000 Technical Reference manual <https://...>`__.

Also, is there an English language version of the product
page? Since QEMU's documentation is in English that would
be the better link if it exists. Otherwise we should warn
the reader by adding "(in German)" when we point them at it.

> +
> +The CX7200 supports following devices:

"the following"

> +    - A9 MPCORE
> +        - cortex-a9
> +        - GIC v1
> +        - Generic timer
> +        - wdt
> +    - OCM 256KB
> +    - SMC SRAM@0xe2000000 64MB

The "SRAM@0xe2000000" renders as an email address hyperlink,
which probably isn't what you intended. I don't think the
address of the RAM is particularly important to the reader
of the docs, so we could just omit it.

For docs changes, I recommend making sure your build
is building the docs by passing --enable-docs to configure.
Then you can look at the HTML that is generated in your
build directory under docs/manual/ to check that it hasn't
come out with any unintentional markup issues

> +    - Zynq SLCR
> +    - SPI x2
> +    - QSPI
> +    - UART
> +    - TTC x2
> +    - Gigabit Ethernet Controller
> +    - SD Controller
> +    - XADC
> +    - Arm PrimeCell DMA Controller
> +    - DDR Memory
> +    - DDR Controller
> +    - Beckhoff Communication Controller (CCAT)
> +        - EEPROM Interface
> +        - DMA Controller
> +
> +Following devices are not supported:

"The following"

> +    - I2C

thanks
-- PMM

Reply via email to