[email protected] writes: > From: "Dr. David Alan Gilbert" <[email protected]> > > Split the SRST/ERST case and add some checks. > This is mainly to make it easier to add some checks in following > patches. > > Signed-off-by: Dr. David Alan Gilbert <[email protected]> > --- > scripts/hxtool | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/scripts/hxtool b/scripts/hxtool > index 80516b9437..ea2accef98 100755 > --- a/scripts/hxtool > +++ b/scripts/hxtool > @@ -2,15 +2,29 @@ > > hxtoh() > { > - flag=1 > + outsiderst=1
I parsed this "outsider st" and went "WAT? Backtrack... aha". Name it outside_rst? in_h? Or revert sense and call it in_rst? > while read -r str; do > case $str in > HXCOMM*) > ;; > - SRST*|ERST*) flag=$(($flag^1)) > + SRST*) > + if [ $outsiderst -eq 0 ] > + then > + echo "Error: SRST inside another RST" >&2 > + exit 1 > + fi > + outsiderst=0 > + ;; > + ERST*) > + if [ $outsiderst -eq 1 ] > + then > + echo "Error: ERST already outside RST" >&2 > + exit 1 > + fi > + outsiderst=1 > ;; > *) > - test $flag -eq 1 && printf "%s\n" "$str" > + test $outsiderst -eq 1 && printf "%s\n" "$str" > ;; > esac > done
