Re: [PATCH v2 3/4] hw/vfio: Add helper to retrieve device feature

[Cédric Le Goater]

On 1/14/26 11:19, Jonathan Cameron wrote:

On Tue, 13 Jan 2026 11:37:53 +0000
Shameer Kolothum <skolothum...@nvidia.com> wrote:

Add vfio_device_get_feature() as a common helper to retrieve
VFIO device features.

No functional change intended.

Signed-off-by: Shameer Kolothum <skolothum...@nvidia.com>

Hi Shameer,

Happy new year.

Trivial thing noticed whilst glancing at this.

diff --git a/hw/vfio/device.c b/hw/vfio/device.c
index 100532f35d..0d9f42a1f0 100644
--- a/hw/vfio/device.c
+++ b/hw/vfio/device.c
@@ -516,6 +516,7 @@ void vfio_device_unprepare(VFIODevice *vbasedev)
      vbasedev->bcontainer = NULL;
  }

+

Stray change.

Yeah I can fix that when applying. No need to resend.

Thanks,

C.

  bool vfio_device_get_viommu_flags_want_nesting(VFIODevice *vbasedev)
  {
      VFIOPCIDevice *vdev = vfio_pci_from_vfio_device(vbasedev);
@@ -527,6 +528,15 @@ bool vfio_device_get_viommu_flags_want_nesting(VFIODevice 
*vbasedev)
      return false;
  }