Hi Cédric > Subject: Re: [PATCH v1 1/1] pc-bios: Update vbootrom image to commit > 1c8e9510b22c > > Hello Jamin, > > On 1/16/26 02:20, Jamin Lin wrote: > >> From: Cédric Le Goater <[email protected]> > >> Sent: Friday, January 16, 2026 12:21 AM > >> To: Nabih Estefan <[email protected]>; Jamin Lin > >> <[email protected]> > >> Cc: [email protected]; [email protected]; Troy Lee > >> <[email protected]>; [email protected]; > [email protected] > >> Subject: Re: [PATCH v1 1/1] pc-bios: Update vbootrom image to commit > >> 1c8e9510b22c > >> > >> hmm, I didn't receive the initial email. > >> > > > > Cédric, > > > > I used the following command to generate a patch to update the pre-built > vbootrom images: > > > > git format-patch -o ../v1-patch HEAD~1 > > > > However, when I ran get_maintainer.pl, it could not find any maintainers and > printed the following message: > > > > ./scripts/get_maintainer.pl -f > > ../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b. > > patch > > get_maintainer.pl: No maintainers found, printing recent contributors. > > get_maintainer.pl: Do not blindly cc: them on patches! Use common sense. > > Weird. MAINTAINERS has : > > Nuvoton NPCM7xx > ... > F: pc-bios/npcm7xx_bootrom.bin > F: pc-bios/npcm8xx_bootrom.bin > F: roms/vbootrom > > We do lack a MAINTAINERS entry for Aspeed : > > F: pc-bios/ast27x0_bootrom.bin > > Can you please send an update ? > > > > > > > fatal: ../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e95 > 10b.patch: > '../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b.p > atch' is outside repository at > '/home/jamin_lin/upstream/qemu/vbootrom/qemu' > > [email protected] (open list:All patches CC here) > > > > As a result, only the mailing list was suggested: > > Eventually, I sent the patch using the following command > > > > git send-email -cc [email protected] -cc > > [email protected] -cc --to [email protected] --to > > [email protected] --to [email protected] ../v1-patch/*.patch > > --no-smtp-auth --smtp-domain=mail.aspeedtech.com > > Looks correct. > > I hope my provider OVH is not silently dropping email :/ The same thing > happened with an email from Kane. Was any email returned to you ? > > > It seems that I included you in the --to list. Do I need to resend the > > patch? > > You do need to resend for another reason : roms/vbootrom needs an update > too. > > Also, for updates with large binaries, for FW updates typically, we prefer > subsystem PRs : > > See an example for a SLOF update from Thomas : > > > https://lore.kernel.org/qemu-devel/[email protected] > om/ > > Some docs here : > > https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html > > Ping me if you need help setting up your environment, >
This is my first time submitting a pull request. Please let me know if there is anything incorrect. https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/ Thanks-Jamin > Thanks, > > C. >
