Re: [PATCH v16 15/26] whpx: add arm64 support

[Mohamed Mediouni]

> On 16. Jan 2026, at 15:21, Philippe Mathieu-Daudé <phi...@linaro.org> wrote:
> 
> On 16/1/26 14:52, Mohamed Mediouni wrote:
>> Signed-off-by: Mohamed Mediouni <moha...@unpredictable.fr>
>> Reviewed-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
>> ---
>>  accel/whpx/whpx-common.c    |   1 +
>>  target/arm/meson.build      |   1 +
>>  target/arm/whpx/meson.build |   3 +
>>  target/arm/whpx/whpx-all.c  | 810 ++++++++++++++++++++++++++++++++++++
>>  4 files changed, 815 insertions(+)
>>  create mode 100644 target/arm/whpx/meson.build
>>  create mode 100644 target/arm/whpx/whpx-all.c
> 
> 
>> +void whpx_apply_breakpoints(
>> +    struct whpx_breakpoint_collection *breakpoints,
>> +    CPUState *cpu,
>> +    bool resuming)
>> +{
>> +
> 
>        g_assert_not_reached() ?
> 
>> +}
>> +void whpx_translate_cpu_breakpoints(
>> +    struct whpx_breakpoints *breakpoints,
>> +    CPUState *cpu,
>> +    int cpu_breakpoint_count)
>> +{
>> +
> 
>        g_assert_not_reached() ?
> 
>> +}
> 
Hello,

Called unconditionally today from the common code. But does nothing as 
breakpoints aren’t supported on the platform.

If trying to actually enable a breakpoint, common code will go through 
whpx_set_exception_exit_bitmap and error there.