On 13/06/12 12:58, Jan Kiszka wrote:
>> Thinking about this a bit more, how about
>>
>> } else if (!kvm_arch_vmalloc(size, &new_block->host)) {
>> <normal code>
>> }
>>I like that. Of course, we have to have a generic kvm_arch_vmalloc implementation then. >> Then the arch specific code could do the check and the implementation of >> vmalloc, but only has to return -1 if we don't need it and things still >> fall back to the generic code. > > But you would have to walk a while to find out that only s390x on (old) > KVM actually returns success here and does some allocation. It that such a problem? What about adding a comment then, otherwise we just use ifdef as a comment, which isnt nice either. Christian
