+ Cedric Hi Michael,
> Subject: Re: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c > > On 1/16/26 10:30, Jamin Lin wrote: > > ---------------------------------------------------------------- > > vbootrom update pull request > > > > ---------------------------------------------------------------- > > Hi Jamin! > > I've become curious. > > You sent a pull request (and second one), listing multiple people in To: and > Cc: > fields. Usually, this is done when you're sending a patch series for review. > For a pull request, usually it's enough to list [email protected] in the > To: > field, and maybe the current person who's managing the master branch, who's > merging the pull requests. Listing multiple people for the pull request makes > not much sense, since a pullreq is something which is (almost) cast in stone > already, it is being merged as-is, there's no way to comment on it or to > modify > it - since the whole pull request is being applied to the master branch as-is. > Got it, thanks for the clarification. This is my first time sending a pull request, so I’m still learning the QEMU PR workflow. Thank you for pointing this out. I created this pull request because it updates the pre-built VBOOTROM image. The patch size is quite large, and both my maintainer and reviewer (Cedric) suggested that I submit it as a pull request instead of a regular patch series. Since I understood that the pull request still needs to be reviewed, I used git send-email together with get_maintainer.pl to include the relevant maintainers and reviewers. git send-email -cc [email protected] -cc [email protected] -cc [email protected] --to-cmd "./scripts/get_maintainer.pl ../v3-patch/*.patch" > And another question is why did you add my address to the list of recipients? > Is it for me to review the changes, or to pick them up through qemu-trivial > tree > (in which case it shouldn't be pull request), or to pick it up for > qemu-stable? > I added your address because it was automatically included by get_maintainer.pl. This pull request is intended for the master branch only. Thanks-Jamin > Thanks, > > /mjt
