On Fri, 9 Jan 2026 at 18:14, Fabiano Rosas <[email protected]> wrote:
> MigrationState is not used at migration_tls_channel_process_incoming().
* MigrationState -> MigrationState parameter
* at -> in
> The last usage was removed by commit 3f461a0c0b ("migration: Drop
> unused parameter for migration_tls_get_creds()")
>
> Reviewed-by: Peter Xu <[email protected]>
> Signed-off-by: Fabiano Rosas <[email protected]>
> ---
> migration/channel.c | 3 +--
> migration/tls.c | 4 +---
> migration/tls.h | 4 +---
> 3 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/migration/channel.c b/migration/channel.c
> index 4768c71455..b4ab676048 100644
> --- a/migration/channel.c
> +++ b/migration/channel.c
> @@ -32,7 +32,6 @@
> */
> void migration_channel_process_incoming(QIOChannel *ioc)
> {
> - MigrationState *s = migrate_get_current();
> MigrationIncomingState *mis = migration_incoming_get_current();
> Error *local_err = NULL;
>
> @@ -40,7 +39,7 @@ void migration_channel_process_incoming(QIOChannel *ioc)
> ioc, object_get_typename(OBJECT(ioc)));
>
> if (migrate_channel_requires_tls_upgrade(ioc)) {
> - migration_tls_channel_process_incoming(s, ioc, &local_err);
> + migration_tls_channel_process_incoming(ioc, &local_err);
> } else {
> migration_ioc_register_yank(ioc);
> migration_ioc_process_incoming(ioc, &local_err);
> diff --git a/migration/tls.c b/migration/tls.c
> index 56b5d1cc90..1df31bdcbb 100644
> --- a/migration/tls.c
> +++ b/migration/tls.c
> @@ -71,9 +71,7 @@ static void migration_tls_incoming_handshake(QIOTask *task,
> object_unref(OBJECT(ioc));
> }
>
> -void migration_tls_channel_process_incoming(MigrationState *s,
> - QIOChannel *ioc,
> - Error **errp)
> +void migration_tls_channel_process_incoming(QIOChannel *ioc, Error **errp)
> {
> QCryptoTLSCreds *creds;
> QIOChannelTLS *tioc;
> diff --git a/migration/tls.h b/migration/tls.h
> index 58b25e1228..7607cfe803 100644
> --- a/migration/tls.h
> +++ b/migration/tls.h
> @@ -24,9 +24,7 @@
> #include "io/channel.h"
> #include "io/channel-tls.h"
>
> -void migration_tls_channel_process_incoming(MigrationState *s,
> - QIOChannel *ioc,
> - Error **errp);
> +void migration_tls_channel_process_incoming(QIOChannel *ioc, Error **errp);
>
> QIOChannelTLS *migration_tls_client_create(QIOChannel *ioc,
> const char *hostname,
> --
* Looks right.
Reviewed-by: Prasad Pandit <[email protected]>
Thank you.
---
- Prasad
