On 20/01/2026 08.56, Prasad Pandit wrote:
On Fri, 9 Jan 2026 at 18:06, Fabiano Rosas <[email protected]> wrote:
There's currently no OS level test for ppc64le. Add one such test by
reusing the boot level tests that are already present.

The test boots the source machine, waits for it to reach a mid-boot
message, migrates and checks that the destination has reached the
final boot message (VFS error due to no disk).

Reviewed-by: Thomas Huth <[email protected]>
Signed-off-by: Fabiano Rosas <[email protected]>
---
  tests/functional/ppc64/test_migration.py | 12 ++++++++
  tests/functional/ppc64/test_pseries.py   | 35 ++++++++++++++++++++++++
  2 files changed, 47 insertions(+)

diff --git a/tests/functional/ppc64/test_migration.py 
b/tests/functional/ppc64/test_migration.py
index 5dfdaaf709..a3b819680b 100755
--- a/tests/functional/ppc64/test_migration.py
+++ b/tests/functional/ppc64/test_migration.py
@@ -4,6 +4,7 @@
  #
  # ppc migration test

+from qemu_test.ports import Ports
  from migration import MigrationTest


@@ -21,6 +22,17 @@ def test_migration_with_exec(self):
          self.set_machine('mac99')
          self.migration_with_exec()

+    def do_migrate_ppc64_linux(self, source_vm, dest_vm):
+        with Ports() as ports:
+            port = ports.find_free_port()
+            if port is None:
+                self.skipTest('Failed to find a free port')
+            uri = 'tcp:localhost:%u' % port

* When port is None, shouldn't it return after the skipTest() call?
With port = None, uri will become -> 'tcp:localhost:None' OR maybe
port should have default value?

skipTest() aborts the test immediately, the remaining code after this statement is not executed anymore. (I think it internally raises an exception that is caught by the unittest code to mark the test as skipped, but you might better ask a Python wizard if you want to know the gory details. See https://docs.python.org/3/library/unittest.html#unittest-skipping for example)

 HTH,
  Thomas


Reply via email to