On Mon, Jan 19, 2026 at 04:27:29PM -0500, John Snow wrote: > 'tooling' contains depedencies required to run various tools (like > qmp-shell) as well as dependencies required to run "make check", and as > such, we promise that these dependencies can be sourced from the user's > distribution repository or from vendored packages so that "make check" > can be executed offline in an isolated build environment. > > In contrast, pygdbmi is only needed for functional tests and not tests > in general; we do not make the same offline/isolated guarantees for > functional tests, and this dependency group is allowed to fetch > dependencies from PyPI at runtime. > > For the time being, amend the "check-venv" target to install both > dependency groups, to avoid a duplicate dependency between them. By the > end of this series, however, "check-venv" will be eliminated in favor of > always installing "tooling" at configure time and allowing "functests" > to be installed on-demand as needed by meson/ninja. > > Signed-off-by: John Snow <[email protected]> > --- > pythondeps.toml | 10 +++++++++- > tests/Makefile.include | 2 +- > 2 files changed, 10 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
