On 20/01/2026 13.55, Peter Maydell wrote:
On Tue, 20 Jan 2026 at 12:21, Thomas Huth <[email protected]> wrote:
From: Thomas Huth <[email protected]>
The hw_compat_* arrays in hw/core/machine.c should be used for generic
compat settings that might affect all (or at least multiple) machines.
Target specific settings should rather go into the target specific
source files instead. For arm/aarch64, the virt machine is the only
one that cares about compat settings, so move the "arm-cpu" related
switches to hw/arm/virt.c now.
I think it makes more sense for all the compat stuff to
live in one place, rather than being scattered around,
unless it is truly machine-specific (which this isn't).
It's only used by the arm virt machine, so it's IMHO machine specific.
If we will ever get other versionized arm machines, they won't use these
config knobs, so this never will be shared with another machine.
The hw/core arrays seem to be where we put compat
props which are related to a particular device rather
than a specific machine.
IMHO it makes sense if multiple machines use such config knobs, but if it is
really only related to one machine ... not so much.
Thomas
