On 25/12/18 02:03PM, Caleb Schlossin wrote: > This commit adds the read/write functionality for few core and > quad registers. > > Signed-off-by: Chalapathi V <[email protected]> > Signed-off-by: Caleb Schlossin <[email protected]> > --- > hw/ppc/pnv_core.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 81 insertions(+) > > > <...snip...> > > @@ -589,6 +653,23 @@ static void pnv_quad_power10_xscom_write(void *opaque, > hwaddr addr, > uint32_t offset = addr >> 3; > > switch (offset) { > + case P10_XSCOM_EQ0_MODE_REG1: > + case P10_XSCOM_EQ0_NCU_SPEC_BAR_REG: > + case P10_XSCOM_EQ0_HTM_MODE: > + case P10_XSCOM_EQ0_HTM_IMA_PDBAR: > + case P10_XSCOM_EQ1_MODE_REG1: > + case P10_XSCOM_EQ1_NCU_SPEC_BAR_REG: > + case P10_XSCOM_EQ1_HTM_MODE: > + case P10_XSCOM_EQ1_HTM_IMA_PDBAR: > + case P10_XSCOM_EQ2_MODE_REG1: > + case P10_XSCOM_EQ2_NCU_SPEC_BAR_REG: > + case P10_XSCOM_EQ2_HTM_MODE: > + case P10_XSCOM_EQ2_HTM_IMA_PDBAR: > + case P10_XSCOM_EQ3_MODE_REG1: > + case P10_XSCOM_EQ3_NCU_SPEC_BAR_REG: > + case P10_XSCOM_EQ3_HTM_MODE: > + case P10_XSCOM_EQ3_HTM_IMA_PDBAR: > + break; > default: > qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__, > offset);
Similar to patch 1, we are masking a warning. Though I don't have strong opposition here, as many of these regs will likely never be implemented in qemu, like the fir and those eq xscoms etc. Hence, looks good to me: Reviewed-by: Aditya Gupta <[email protected]> Thanks, - Aditya G
