> -----Original Message----- > From: Cédric Le Goater <[email protected]> > Sent: Monday, January 26, 2026 4:57 PM > To: Kane Chen <[email protected]>; Peter Maydell > <[email protected]>; Steven Lee <[email protected]>; Troy > Lee <[email protected]>; Jamin Lin <[email protected]>; Andrew > Jeffery <[email protected]>; Joel Stanley <[email protected]>; > open list:ASPEED BMCs <[email protected]>; open list:All patches CC > here <[email protected]> > Cc: Troy Lee <[email protected]> > Subject: Re: [PATCH v5 03/22] hw/misc: Add basic Aspeed PWM model > > On 1/20/26 06:18, Kane Chen via wrote: > > From: Cédric Le Goater <[email protected]> > > > > Add an initial PWM model for Aspeed SoCs, including device state, > > register definitions, and basic initialization as a sysbus device. > > > > Signed-off-by: Cédric Le Goater <[email protected]> > > Signed-off-by: Kane-Chen-AS <[email protected]> > > --- > > include/hw/arm/aspeed_soc.h | 3 +- > > include/hw/misc/aspeed_pwm.h | 31 +++++++++ > > hw/misc/aspeed_pwm.c | 121 > +++++++++++++++++++++++++++++++++++ > > hw/misc/meson.build | 1 + > > hw/misc/trace-events | 4 ++ > > 5 files changed, 159 insertions(+), 1 deletion(-) > > create mode 100644 include/hw/misc/aspeed_pwm.h > > create mode 100644 hw/misc/aspeed_pwm.c > Kane, > > When you resend, could you please fix : > > ERROR: New file 'include/hw/misc/aspeed_pwm.h' requires > 'SPDX-License-Identifier' > ERROR: New file 'hw/misc/aspeed_pwm.c' requires > 'SPDX-License-Identifier' > > > ERRORs detected by ../scripts/checkpatch.pl should be fixed before sending. > WARNING are OK. > > Thanks, > > C.
Hi Cédric, Thanks for the catch. I missed the SPDX errors because I was running checkpatch.pl -f on the source files instead of the generated patches. I will fix these errors in the next version. Best Regards, Kane
