On Tue, Jan 27, 2026 at 12:09:16PM -0300, Fabiano Rosas wrote: > Fix a couple of leaks detected by Coverity. Both are currently > harmless. > > - set_StrOrNull: the visitor should never fail unless there's a > programming error and a property of different type has been passed in. > > Change it to only allocate memory after the visit call has returned > successfully. > > - get_StrOrNull: the whole of the getter is unused, it's only purpose at > the moment is to provide a complete implementation of the StrOrNull > property. If it were used, it would always receive a non-NULL pointer > because this property is part of s->parameters and always initialized > by the setter. > > Assert non-NULL instead of allocating a new object. > > Fixes: CID 1643919 > Fixes: CID 1643920 > Reported-by: Peter Maydell <[email protected]> > Signed-off-by: Fabiano Rosas <[email protected]>
Reviewed-by: Peter Xu <[email protected]> -- Peter Xu
