Hello Peter, thank you for looking. On Thu, Jan 29, 2026 at 12:31 PM Peter Maydell <[email protected]> wrote: > > How would you prefer I proceed? > There is also option 4: > > 4) Don't change this, because QEMU is not a C++ project > and it's not a goal for our headers to be compilable > with C++, with some minor exceptions. > > What are we trying to achieve here, and why does it benefit > us as an upstream project ?
The Goal: to cleanup the specific header include/ui/kbd-state.h by removing a redundant enum declaration. I realize my original patch description focused on C++, so I will update the commit message in v2 to reflect this cleanup as the primary goal. The Benefit to Upstream: Currently, this file uses a verbose style where a forward declaration immediately precedes the definition. In this context, the forward declaration is effectively dead code. My patch consolidates this into the cleaner, standard C idiom found elsewhere in the tree (e.g. include/block/block-common.h): We are proposing this change because kbd-state.h is a public interface header causing friction for downstream C++ consumers. By adopting the cleaner C idiom here (which benefits QEMU by removing redundancy), we also resolve that downstream friction as a side effect.
