On Wed, Jan 28, 2026 at 04:55:17PM -0300, Fabiano Rosas wrote: > Peter Xu <[email protected]> writes: > > > This function is used by both COLO and Xen. Simplify it with two changes: > > > > - Remove checks on qemu_savevm_se_iterable(): this is not needed as > > vmstate_save() also checks for "save_state() || vmsd" instead. Here, > > save_setup() (or say, iterable states) should be mutual exclusive to > > "save_state() || vmsd" [*]. > > > > - Remove migrate_error_propagate(): both of the users are not using live > > migration framework, but raw vmstate operations. Error propagation is > > not needed for query-migrate persistence. > > > > s/not needed/only needed/ > > I can fixup if no repost.
I'll fix both issues, including the one in the previous patch. I'll wait for your review on the last patch to complete to see if I should repost. > > > [*] One tricky user is VFIO, who provided _both_ save_state() and > > save_setup(). However VFIO mustn't have been used in these paths or it > > means both COLO and Xen have ignored VFIO data instead (that is, > > qemu_savevm_se_iterable() will return true for VFIO). Hence, this change is > > safe. > > > > Cc: David Woodhouse <[email protected]> > > Cc: Paul Durrant <[email protected]> > > Signed-off-by: Peter Xu <[email protected]> > > Reviewed-by: Fabiano Rosas <[email protected]> Thanks. -- Peter Xu
