> There is a bug in the interface: we don't allow vhostfds argument
> together with queues. But we allow vhostfd, and try use it for all
> queues of multiqueue TAP.
> Let's relax the restriction. We already check that number of vhost fds
> match queues (or number of fds). So, no matter do vhost fds come from
> vhostfds or vhostfd argument. Let's use correct vhost fds for multiqueue
> TAP.
> To achieve this we move vhost fds parsing to separate function and call
> it earlier in net_init_tap(). Then we have vhost fds available (and
> already checked) for all further cases.
I like the idea behind this change, but given that it modifies the API slightly,
can you include and update to the documentation that clarifies which
options are allowed to coexist and in what context?
Thanks,
Ben
