>> >                  region->mmaps[0].size = region->size;
>> > +            } else {
>> > +                return ret;
>> >              }
>>
>> Is this now returns without the trace_xxx , right?
>>
>> With that fixed:
>> Reviewed-by: Shameer Kolothum <[email protected]>
>
> Right, I think this was probably meant to be 'else if (ret)' so the
> newly added -EINVAL generates an error w/o trace while the non-error
> path should fall through.  Thanks,

Thanks for catching that and for the review! Will fix in v2.

Reply via email to