On Fri, Jun 15, 2012 at 8:30 PM, Andreas Färber <afaer...@suse.de> wrote: > Am 15.06.2012 12:06, schrieb Li Zhang: >> For pseries machine, it needs to enable usb to add >> keyboard or usb mouse. -usb option won't be used in >> the future, and machine options is a better way to >> enable usb. >> >> So this patch is to add usb option to machine options >> (-machine type=psereis,usb=on/off)to enable/disable >> usb controller. >> >> In this patch, usb_on is an global option which can >> be checked by machines. > [snip] > > ...which is exactly what you've been asked to change in v1. Please do. > OK. I will do it. :)
> Also please stick to QEMU Coding Style, which requires braces for if. > Use of the bool type is preferred of int for two-state logic. > Got it. I will do it carefully in the future. > Regards, > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg > -- Best Regards -Li
