On 11/02/2026 07.58, Choon Keong wrote:
The 'fd-bootchk' option for pc and q35 machines currently lacks of
description in the help output. This makes it difficult for users
to understand the purpose of the command.

This commit solve this issue by adding description using
object_class_property_set_description() in hw/i386/pc.c,
adding the the description message for the option 'fd-bootchk'.

Suggested-by: Peter Maydell <[email protected]>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3193
Signed-off-by: Choon Keong <[email protected]>
---
  hw/i386/pc.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 5cb074c0a0..eb39c18788 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1822,6 +1822,8 @@ static void pc_machine_class_init(ObjectClass *oc, const 
void *data)
      object_class_property_add_bool(oc, "fd-bootchk",
          pc_machine_get_fd_bootchk,
          pc_machine_set_fd_bootchk);
+    object_class_property_set_description(oc, "fd-bootchk",
+        "Enable/disable floppy disk boot check");

I'd maybe use a text based on the description from "-no-fd-bootchk" in the qemu-opions.hx file:

 "Enable/disable boot signature checking for floppy disks in BIOS."

?

... so that it is clear that this influences the behaviour in the BIOS.

 Thomas


Reply via email to