> -----Original Message----- > From: Eric Auger <[email protected]> > Sent: 12 February 2026 06:34 > To: Shameer Kolothum Thodi <[email protected]>; Nicolin Chen > <[email protected]> > Cc: [email protected]; [email protected]; > [email protected]; Nathan Chen <[email protected]>; Matt Ochs > <[email protected]>; Jiandi An <[email protected]>; Jason Gunthorpe > <[email protected]>; [email protected]; > [email protected]; [email protected]; Krishnakant Jaju > <[email protected]> > Subject: Re: [PATCH v5 3/5] hw/arm/smmuv3-accel: Allocate vEVENTQ for > accelerated SMMUv3 devices
> >> Point is: if local_err isn't NULL, why can't we allocate vEVENTQ? > > Technically nothing prevents that I guess. > > > > The only thing is we have to call error_report_err() if local_err != NULL > > and then set local_err == NULL before calling alloc_veventq(). > > Besides the implementation details about Error handle usage I think we > shall first answer the question about the relevance to allocate the > veventq in case the smmuv3_cmdq_consume() fails. Going through the spec, I don’t think there are any architectural dependency between CMDQ and EVENTQ. They are functionally independent of each other, so it would be better to decouple this. Thanks, Shameer
