On Fri, 13 Feb 2026 at 11:52, Daniel P. Berrangé <[email protected]> wrote: > > On Fri, Feb 13, 2026 at 11:48:29AM +0000, Peter Maydell wrote: > > On Fri, 13 Feb 2026 at 11:09, Daniel P. Berrangé <[email protected]> > > wrote: > > > > > > On Fri, Feb 13, 2026 at 11:21:09AM +0100, Paolo Bonzini wrote: > > > > From: Aidan Khoury <[email protected]> > > > > > > > > The new Diamond Rapids x86 cpu model definition that was added in > > > > 7a6dd8bde1 > > > > has an unexpected comma in the `.features[FEAT_VMX_EXIT_CTLS]` subobject > > > > initializer, causing the prior initialization to be overridden. For > > > > this > > > > reason `VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | > > > > VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE` > > > > is not included. > > > > > > > > Fix this by replacing the comma with the missing bitwise OR to properly > > > > combine all the flags into a single bitmask value. > > > > > > > > Fixes: 7a6dd8bde159 ("i386/cpu: Add CPU model for Diamond Rapids") > > > > Signed-off-by: Aidan Khoury <[email protected]> > > > > > > That's missing your S-o-B > > > > > > I have this pullreq tested and ready to apply -- do you think this > > is important enough to respin? > > I'm not that fussed if it is just 1 out of the 41 patches, but I've > not received the other patches in this pull so haven't checked.
Looks like it was just this one patch. -- PMM
