Missing review: #7 Since v1: - Inlined PPC code in patch #7 (Mark)
Slightly rework how the graphic dimension variables for the M68k / PPC / SPARC targets are initialized, removing the need for the target-specific globals-target.c file. Previous discussion: https://lore.kernel.org/qemu-devel/[email protected]/ Philippe Mathieu-Daudé (8): hw/display/macfb: Constify macfb_sense_table[] array hw/display/macfb: Constify macfb_mode_table[] array hw/m68k/q800: Use MacFbMode fields in q800_machine_init() hw/m68k/q800: Set MACFB_DISPLAY_APPLE_21_COLOR within MacFrameBuffer hw/m68k: Set graphic display dimensions generically hw/sparc: Set graphic display dimensions generically hw/ppc: Set graphic display dimensions generically system/globals: Build as common code include/hw/display/macfb.h | 2 +- hw/display/macfb.c | 18 +++++++++++------- hw/m68k/q800.c | 17 ++++++----------- hw/ppc/mac_newworld.c | 9 +++++++++ hw/ppc/mac_oldworld.c | 9 +++++++++ hw/ppc/prep.c | 9 +++++++++ hw/ppc/spapr.c | 9 +++++++++ hw/sparc/sun4m.c | 9 +++++++++ hw/sparc64/sun4u.c | 10 ++++++++++ system/globals-target.c | 24 ------------------------ system/globals.c | 3 +++ system/meson.build | 4 ---- 12 files changed, 76 insertions(+), 47 deletions(-) delete mode 100644 system/globals-target.c -- 2.52.0
