On 2/19/26, 1:10 PM, "Vladimir Sementsov-Ogievskiy" <[email protected] <mailto:[email protected]>> wrote:
>On 19.02.26 20:00, Chaney, Ben wrote: >> >> On 2/18/26, 3:29 PM, "Vladimir Sementsov-Ogievskiy" >> <[email protected] <mailto:[email protected]> >> <mailto:[email protected] <mailto:[email protected]>>> wrote: >> >>> + queues = tap_parse_fds_and_queues(tap, &fds, errp); >>> + if (queues < 0) { >>> + return -1; >>> + } >>> + >> >> Are we appropriately validating that queues != 0? >> I believe we need to throw an error in that case. >> > Agree. I'll add the check into tap_parse_fds_and_queues(). That sounds good. You may need a similar check in net_parse_fds to throw an error on an empty fd list, which would result queues = 0 through a different mechanism. Thanks, Ben
