On Mon, Feb 9, 2026 at 5:10 AM Joel Bueno <[email protected]> wrote: > > Adding jsnow, I forgot to initially add him! Also, bumping again. Thanks and > sorry for the bumps.
Hi, sorry, what's the context here? I don't believe I've worked on this device before, what type of review are you hoping for from me? > > On Wed, Jan 7, 2026 at 12:29 Joel Bueno <[email protected]> wrote: >> >> Is there any feedback on this patch series? >> >> On Sun, Dec 21, 2025 at 11:53 Joel Bueno <[email protected]> wrote: >>> >>> The Fast Read (0Bh) instruction requires 8 dummy clock cycles >>> according to Winbond datasheets (e.g., W25Q256JV Section 8.2.12). >>> However, the current code adds 8 to needed_bytes, which represents >>> bytes, not clock cycles. Since 8 clock cycles equals 1 byte in SPI >>> communication (1 bit per clock edge), this results in 64 dummy >>> clock cycles instead of 8. >>> >>> Change the Winbond case to add 1 byte (8 clocks) instead of 8 bytes >>> (64 clocks), matching the existing implementation for SST flash and >>> the datasheet specifications. >>> >>> Signed-off-by: Joel Bueno <[email protected]> >>> --- >>> hw/block/m25p80.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c >>> index a5336d92ff..21c2118b33 100644 >>> --- a/hw/block/m25p80.c >>> +++ b/hw/block/m25p80.c >>> @@ -1001,7 +1001,7 @@ static void decode_fast_read_cmd(Flash *s) >>> s->needed_bytes += 1; >>> break; >>> case MAN_WINBOND: >>> - s->needed_bytes += 8; >>> + s->needed_bytes += 1; >>> break; >>> case MAN_NUMONYX: >>> s->needed_bytes += numonyx_extract_cfg_num_dummies(s); >>> -- >>> 2.51.0 >>>
