On 2/23/26 8:32 AM, Igor Mammedov wrote:
On Fri, 20 Feb 2026 19:14:37 +0100
David Hoppenbrouwers <[email protected]> wrote:

The command ID is in cmd[0], not cmd[1].
pls add a reference to the spec,
and if any what impact it does have on a guest/how it manifests.

Figure 43 "Generic Command Buffer Entry Format" in
https://docs.amd.com/v/u/en-US/48882_3.10_PUB
But the switch() above also uses cmd[0]:

    switch (extract64(cmd[0], 60, 4)) {
    case AMDVI_CMD_COMPLETION_WAIT:
        amdvi_completion_wait(s, cmd);
        break;

It has no effect on the guest, only on the -trace option. It may be confusing to developers if the actual command ID doesn't match what is shown by -trace.

David

Reply via email to