> -----Original Message-----
> From: Jonathan Cameron <[email protected]>
> Sent: 24 February 2026 14:14
> To: Shameer Kolothum Thodi <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Nicolin Chen
> <[email protected]>; Nathan Chen <[email protected]>; Matt Ochs
> <[email protected]>; Jiandi An <[email protected]>; Jason Gunthorpe
> <[email protected]>; [email protected]; [email protected];
> Krishnakant Jaju <[email protected]>
> Subject: Re: [PATCH v7 2/5] hw/arm/smmuv3-accel: Add viommu free helper
>
> External email: Use caution opening links or attachments
>
>
> On Thu, 19 Feb 2026 09:01:00 +0000
> Shameer Kolothum <[email protected]> wrote:
>
> > Move viommu teardown into a helper function and use it from the
> > last device removal path. No functional change.
>
> Minor thing, but this description should really include 'why' factoring this
> out makes sense. I was kind of assuming reuse, but there doesn't seem to be
> any in this series. So I guess just grouping related code for readability?
Right, this is primarily for grouping related teardown logic and
improving readability.
It also provides a single place to extend the teardown in future,
e.g., when freeing related objects such as vEVENTQ.
>
> >
> > Reviewed-by: Nicolin Chen <[email protected]>
> > Reviewed-by: Eric Auger <[email protected]>
> > Tested-by: Nicolin Chen <[email protected]>
> > Signed-off-by: Shameer Kolothum <[email protected]>
> Reviewed-by: Jonathan Cameron <[email protected]>
Thanks,
Shameer
