On Tue, 24 Feb 2026 at 16:32, <[email protected]> wrote: > > From: Marc-André Lureau <[email protected]> > > The NULL checks for be, name, callback_fn, and as in > audio_mixeng_backend_open_{in,out} are redundant: the callers > audio_be_open_{in,out} already assert that name, callback_fn, and as > are non-NULL, and dereference be unconditionally via > AUDIO_BACKEND_GET_CLASS(be) before the call. > > Signed-off-by: Marc-André Lureau <[email protected]> > --- > audio/audio_template.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/audio/audio_template.h b/audio/audio_template.h > index 228369cf9a1..fe769cde667 100644 > --- a/audio/audio_template.h > +++ b/audio/audio_template.h > @@ -497,12 +497,6 @@ static SW *glue(audio_mixeng_backend_open_, TYPE) ( > AudioMixengBackendClass *k; > AudiodevPerDirectionOptions *pdo; > > - if (!be || !name || !callback_fn || !as) { > - audio_bug("backend=%p name=%p callback_fn=%p as=%p", > - be, name, callback_fn, as); > - goto fail; > - } > -
Reviewed-by: Peter Maydell <[email protected]> thanks -- PMM
