On 2/25/26 03:52, Peter Maydell wrote:
On Mon, 16 Feb 2026 at 03:46, Richard Henderson
<[email protected]> wrote:

Signed-off-by: Richard Henderson <[email protected]>
---
  target/arm/kvm.c | 27 ++++++++++++---------------
  1 file changed, 12 insertions(+), 15 deletions(-)



@@ -2139,8 +2138,7 @@ static int kvm_arch_put_sve(CPUState *cs)
      }

      for (n = 0; n < KVM_ARM64_SVE_NUM_PREGS; ++n) {
-        r = sve_bswap64(tmp, r = &env->vfp.pregs[n].p[0],
-                        DIV_ROUND_UP(cpu->sve_max_vq * 2, 8));

What was going on with the double assignment to 'r' in the old code ??

No idea.

I suspect they used to be separate statements, but got smushed somehow.

r~


+        r = sve_bswap64(tmp, &env->vfp.pregs[n].p[0], DIV_ROUND_UP(vq * 2, 8));
          ret = kvm_set_one_reg(cs, KVM_REG_ARM64_SVE_PREG(n, 0), r);
          if (ret) {
              return ret;

Anyway
Reviewed-by: Peter Maydell <[email protected]>

thanks
-- PMM


Reply via email to