Re: [PATCH v6 35/35] migration: return EEXIST when trying to add the same migration blocker

[Prasad Pandit]

On Wed, 25 Feb 2026 at 09:23, Ani Sinha <anisi...@redhat.com> wrote:
> Currently the code that adds a migration blocker does not check if the same
> blocker already exists. Return an EEXIST error code if there is an attempt to
> add the same migration blocker again. This way the same migration blocker will
> not get added twice.
>
> Suggested-by: Prasad Pandit <p...@fedoraproject.org>
> Signed-off-by: Ani Sinha <anisi...@redhat.com>
> ---
>  migration/migration.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index a5b0465ed3..1eb75fb7fb 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1702,6 +1702,10 @@ static int add_blockers(Error **reasonp, unsigned 
> modes, Error **errp)
>  {
>      for (MigMode mode = 0; mode < MIG_MODE__MAX; mode++) {
>          if (modes & BIT(mode)) {
> +            if (g_slist_index(migration_blockers[mode],
> +                                 *reasonp) >= 0) {
> +                return -EEXIST;
> +            }
>              migration_blockers[mode] = 
> g_slist_prepend(migration_blockers[mode],
>                                                         *reasonp);
>          }

* Looks okay.
Reviewed-by: Prasad Pandit <p...@fedoraproject.org>

Thank you.
---
  - Prasad