On 2/24/26 16:05, Marc-André Lureau wrote:
Hi
On Mon, Feb 23, 2026 at 9:27 PM Sergei Heifetz <[email protected]> wrote:
It does not matter much whether `-audio none` is passed. In the future,
support for `-audio none` with `--disable-audio` will be dropped, so we
should remove it beforehand.
Signed-off-by: Sergei Heifetz <[email protected]>
Reviewed-by: Thomas Huth <[email protected]>
Tbh, I feel like we could still allow "-audio none" for compatibility
reasons, even if compiled without CONFIG_AUDIO. But "-audio none" does
not mean "no audio"! it's actually the "none" backend, so better to
remove "-audio" altogether indeed. It may be worth explaining that in
the commit message.
Reviewed-by: Marc-André Lureau <[email protected]>
Yes, that was my reasoning as well. I’ll explain it in the commit message.
---
tests/qtest/libqtest.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 794d870085..adb968f40e 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -464,7 +464,9 @@ gchar *qtest_qemu_args(const char *extra_args)
"-chardev socket,path=%s,id=char0 "
"-mon chardev=char0,mode=control "
"-display none "
+#ifdef CONFIG_AUDIO
"-audio none "
+#endif
"%s"
"%s"
" -accel qtest",
--
2.34.1
--
Marc-André Lureau
