Re: [PATCH 2/3] hw/i386/intel_iommu: Avoid including CONFIG_DEVICES in hw/ header

[Thomas Huth]

On 25/02/2026 04.16, Philippe Mathieu-Daudé wrote:
By inlinining the stubs we can avoid the use of target-specific

s/By inlining the stubs/By turning the inline functions into stubs/ ?

CONFIG_DEVICES include in a hw/ header, allowing to build the
source files including it as common objects.

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  hw/i386/intel_iommu_accel.h       | 35 ++---------------------------
  hw/i386/intel_iommu_accel-stubs.c | 37 +++++++++++++++++++++++++++++++
  hw/i386/meson.build               |  1 +
  3 files changed, 40 insertions(+), 33 deletions(-)
  create mode 100644 hw/i386/intel_iommu_accel-stubs.c

diff --git a/hw/i386/intel_iommu_accel.h b/hw/i386/intel_iommu_accel.h
index e5f0b077b4b..d75d232c6d4 100644
--- a/hw/i386/intel_iommu_accel.h
+++ b/hw/i386/intel_iommu_accel.h
@@ -10,9 +10,9 @@
  
  #ifndef HW_I386_INTEL_IOMMU_ACCEL_H
  #define HW_I386_INTEL_IOMMU_ACCEL_H
-#include CONFIG_DEVICES
  
-#ifdef CONFIG_VTD_ACCEL
+#include "hw/i386/intel_iommu_internal.h"
Why is this #include suddenly required? ... please add a comment about this 
to the patch description!

 Thanks,
  Thomas