Currently the code that adds a migration blocker does not check if the same blocker already exists. Return an EEXIST error code if there is an attempt to add the same migration blocker again. This way the same migration blocker will not get added twice.
Suggested-by: Prasad Pandit <[email protected]> Reviewed-by: Prasad Pandit <[email protected]> Signed-off-by: Ani Sinha <[email protected]> --- migration/migration.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index a5b0465ed3..eb82e964b2 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1702,6 +1702,12 @@ static int add_blockers(Error **reasonp, unsigned modes, Error **errp) { for (MigMode mode = 0; mode < MIG_MODE__MAX; mode++) { if (modes & BIT(mode)) { + if (g_slist_index(migration_blockers[mode], + *reasonp) >= 0) { + error_propagate_prepend(errp, *reasonp, + "migration blocker already added for: "); + return -EEXIST; + } migration_blockers[mode] = g_slist_prepend(migration_blockers[mode], *reasonp); } -- 2.42.0
