On Thu, 26 Feb 2026 18:08:09 +0100 Philippe Mathieu-Daudé <[email protected]> wrote:
> Hi Igor, > > On 6/2/26 14:14, Igor Mammedov wrote: > > It will be used by following code to enable ACPI watchdog. > > Initial support will bring it to Q35 and arm/virt machines using > > respective iTCO and GWDT watchdogs as hardware backend. > > > > Signed-off-by: Igor Mammedov <[email protected]> > > --- > > include/hw/core/boards.h | 1 + > > hw/core/machine.c | 20 ++++++++++++++++++++ > > 2 files changed, 21 insertions(+) > > > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > index 6411e68856..4ca808fb73 100644 > > --- a/hw/core/machine.c > > +++ b/hw/core/machine.c > > @@ -499,6 +499,20 @@ static void machine_set_usb(Object *obj, bool value, > > Error **errp) > > ms->usb_disabled = !value; > > } > > > > +static bool machine_get_acpi_watchdog(Object *obj, Error **errp) > > +{ > > + MachineState *ms = MACHINE(obj); > > + > > + return ms->acpi_watchdog; > > +} > > + > > +static void machine_set_acpi_watchdog(Object *obj, bool value, Error > > **errp) > > +{ > > + MachineState *ms = MACHINE(obj); > > + > > + ms->acpi_watchdog = value; > > +} > > + > > static bool machine_get_graphics(Object *obj, Error **errp) > > { > > MachineState *ms = MACHINE(obj); > > @@ -1257,6 +1271,12 @@ static void machine_class_init(ObjectClass *oc, > > const void *data) > > NULL, NULL); > > object_class_property_set_description(oc, "memory", > > "Memory size configuration"); > > + > > + object_class_property_add_bool(oc, "acpi-watchdog", > > + machine_get_acpi_watchdog, machine_set_acpi_watchdog); > > + object_class_property_set_description(oc, "acpi-watchdog", > > + "Set on/off to enable/disable ACPI watchdog." > > + " Default: off (ACPI watchdog is disabled)."); > > Should we check for CONFIG_ACPI somewhere? I do check it when I build wdat specific files. Anyways, this part has been reworked see my reply in 8/11 thread with new more generic 'watchdog' option. > > > } >
