On Mon, Mar 2, 2026 at 11:39 AM Cédric Le Goater <[email protected]> wrote: > > The size of the is_rsvd lookup table in i3c_addr_is_rsvd() is 255 but > should be 256 to cover all possible uint8_t address values and avoid > potential out-of-bounds access. > > The array should be static too as it's a constant lookup table. > > Signed-off-by: Cédric Le Goater <[email protected]> > --- > hw/i3c/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i3c/core.c b/hw/i3c/core.c > index 8a37099ce3ff..0a266e00a279 100644 > --- a/hw/i3c/core.c > +++ b/hw/i3c/core.c > @@ -525,7 +525,7 @@ int i3c_target_ibi_finish(I3CTarget *t, uint8_t data) > > static bool i3c_addr_is_rsvd(uint8_t addr) > { > - const bool is_rsvd[255] = { > + static const bool is_rsvd[256] = {
Given that we're using hex addressing for the values in is_rsvd, could we make the size `0xff` so it maintains the same formatting? Otherwise, it looks good to me. Reviewed-by: Nabih Estefan <[email protected]> > [0x00] = true, > [0x01] = true, > [0x02] = true, > -- > 2.53.0 >
