On 03.03.26 18:38, Peter Xu wrote:
On Sat, Feb 21, 2026 at 12:02:05AM +0300, Vladimir Sementsov-Ogievskiy wrote:
Simplify vmstate_save_state() which is rather big, and simplify further
refactoring.
Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
I wonder how hard it is to have this helper also cover the rest in the loop
over elements, on e.g. VMS_ARRAY_OF_POINTER, vmdesc_loop being able to
change, and all the nullptr handling.
I had a feeling that you intentionally skipped those because it'll not be
as trivial
Yes, at least it would make me to dig deeper and understand the logic
around vmdesc and vmdesc_loop :) So I decided to limit the change to
what I need for further conversion to bool+errp.
- I think it's fine, but IIUC we can always figure a way out.
Can be done later. Agree this is an improvement already,
Reviewed-by: Peter Xu <[email protected]>
--
Best regards,
Vladimir
