Re: [PATCH v18 5/8] acpi: Add parameters to pass cache descriptions to ACPI build_pptt()

[Gustavo Romero]

Hi Alireza,

On 2/20/26 11:11, Alireza Sanaee wrote:

Add optional parameters to pass cache descriptions to build_pptt().
Update ARM and Loongarch callers to pass none for now.

Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com>
Signed-off-by: Alireza Sanaee <alireza.san...@huawei.com>
---
  hw/acpi/aml-build.c            | 3 ++-
  hw/arm/virt-acpi-build.c       | 2 +-
  hw/loongarch/virt-acpi-build.c | 4 ++--
  include/hw/acpi/aml-build.h    | 4 +++-
  4 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index ea1c415b21..b75aa2336e 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -2153,7 +2153,8 @@ void build_spcr(GArray *table_data, BIOSLinker *linker,
   * 5.2.29 Processor Properties Topology Table (PPTT)
   */
  void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
-                const char *oem_id, const char *oem_table_id)
+                const char *oem_id, const char *oem_table_id,
+                int num_caches, CPUCoreCaches *caches)
  {
      MachineClass *mc = MACHINE_GET_CLASS(ms);
      CPUArchIdList *cpus = ms->possible_cpus;
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 544004615d..a655d1e42b 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -1277,7 +1277,7 @@ void virt_acpi_build(VirtMachineState *vms, 
AcpiBuildTables *tables)
      if (!vmc->no_cpu_topology) {
          acpi_add_table(table_offsets, tables_blob);
          build_pptt(tables_blob, tables->linker, ms,
-                   vms->oem_id, vms->oem_table_id);
+                   vms->oem_id, vms->oem_table_id, 0, NULL);
      }

acpi_add_table(table_offsets, tables_blob);

diff --git a/hw/loongarch/virt-acpi-build.c b/hw/loongarch/virt-acpi-build.c
index 3e34bedcd6..a0b445f297 100644
--- a/hw/loongarch/virt-acpi-build.c
+++ b/hw/loongarch/virt-acpi-build.c
@@ -538,8 +538,8 @@ static void acpi_build(AcpiBuildTables *tables, 
MachineState *machine)
      build_madt(tables_blob, tables->linker, lvms);

acpi_add_table(table_offsets, tables_blob);

-    build_pptt(tables_blob, tables->linker, machine,
-               lvms->oem_id, lvms->oem_table_id);
+    build_pptt(tables_blob, tables->linker, machine, lvms->oem_id,
+               lvms->oem_table_id, 0, NULL);

acpi_add_table(table_offsets, tables_blob);

      build_srat(tables_blob, tables->linker, machine);
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index f38e129719..e70e0643b1 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -3,6 +3,7 @@

#include "hw/acpi/acpi-defs.h"

  #include "hw/acpi/bios-linker-loader.h"
+#include "hw/core/cpu.h"

#define ACPI_BUILD_APPNAME6 "BOCHS "

  #define ACPI_BUILD_APPNAME8 "BXPC    "
@@ -499,7 +500,8 @@ void build_slit(GArray *table_data, BIOSLinker *linker, 
MachineState *ms,
                  const char *oem_id, const char *oem_table_id);

void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,

-                const char *oem_id, const char *oem_table_id);
+                const char *oem_id, const char *oem_table_id,
+                int num_caches, CPUCoreCaches *caches);

void build_fadt(GArray *tbl, BIOSLinker *linker, const AcpiFadtData *f,

                  const char *oem_id, const char *oem_table_id);

Reviewed-by: Gustavo Romero <gustavo.rom...@linaro.org>


Cheers,
Gustavo